-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing wait interval for BQ integration tests #1827
Conversation
… the uploading of the entity_df in integration tests was very slow Signed-off-by: Danny Chiao <danny@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
===========================================
- Coverage 84.60% 63.35% -21.26%
===========================================
Files 94 94
Lines 6946 6950 +4
===========================================
- Hits 5877 4403 -1474
- Misses 1069 2547 +1478
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sdk/python/tests/integration/feature_repos/repo_configuration.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
From some quick logging, a hotspot when running integration tests lies in uploading entity_df for BQ related tests. This reduces the polling interval from 10 seconds to 0.1 seconds in test environments (and also reduce the prod environment interval to 1s since the main cost is catching a raised Exception, but there's nothing else happening on this thread)
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: