Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Registry and CLI operations for on demand feature views #1828

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

achals
Copy link
Member

@achals achals commented Sep 2, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Add Registry and CLI operations for on demand feature views

Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals added the kind/feature New feature or request label Sep 2, 2021
@achals achals requested a review from adchia September 2, 2021 22:56
@achals achals requested review from tsotnet, woop and a team as code owners September 2, 2021 22:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1828 (e479e3e) into master (9dc9e60) will decrease coverage by 0.06%.
The diff coverage is 45.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
- Coverage   84.60%   84.54%   -0.07%     
==========================================
  Files          94       94              
  Lines        6946     7228     +282     
==========================================
+ Hits         5877     6111     +234     
- Misses       1069     1117      +48     
Flag Coverage Δ
integrationtests 84.47% <45.09%> (+0.20%) ⬆️
unittests 63.20% <41.17%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 42.58% <33.33%> (-1.38%) ⬇️
sdk/python/feast/errors.py 67.96% <40.00%> (-1.43%) ⬇️
sdk/python/feast/registry.py 78.30% <61.53%> (-1.00%) ⬇️
sdk/python/feast/feature_store.py 92.66% <66.66%> (-0.49%) ⬇️
sdk/python/feast/infra/offline_stores/redshift.py 89.54% <0.00%> (-0.75%) ⬇️
...python/feast/infra/offline_stores/offline_store.py 84.00% <0.00%> (ø)
sdk/python/feast/infra/offline_stores/file.py 97.61% <0.00%> (+0.47%) ⬆️
sdk/python/feast/infra/provider.py 89.58% <0.00%> (+0.79%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 83.82% <0.00%> (+3.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc9e60...e479e3e. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 0d775c2 into feast-dev:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants