-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update historical retrieval integration test for on demand feature views #1836
Update historical retrieval integration test for on demand feature views #1836
Conversation
Signed-off-by: Achal Shah <achals@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1836 +/- ##
==========================================
+ Coverage 84.04% 84.13% +0.09%
==========================================
Files 90 90
Lines 6761 6770 +9
==========================================
+ Hits 5682 5696 +14
+ Misses 1079 1074 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
feast_objects = [] | ||
feast_objects.extend(feature_views.values()) | ||
feast_objects.extend([odfv, driver(), customer()]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still want this to test online retrieval no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, because it's part of feature_views.values()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Tests are good
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: