-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple entities in Redshift #1850
Add support for multiple entities in Redshift #1850
Conversation
cd3c0e2
to
b041810
Compare
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
==========================================
+ Coverage 84.92% 84.97% +0.04%
==========================================
Files 92 92
Lines 7185 7202 +17
==========================================
+ Hits 6102 6120 +18
+ Misses 1083 1082 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/kind bug |
86d74db
to
e31c7bf
Compare
/retest |
7f54ed6
to
0e2bafd
Compare
/retest |
1 similar comment
/retest |
sdk/python/tests/integration/feature_repos/universal/feature_views.py
Outdated
Show resolved
Hide resolved
sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py
Outdated
Show resolved
Hide resolved
…e entities Signed-off-by: Felix Wang <wangfelix98@gmail.com>
…ties Signed-off-by: Felix Wang <wangfelix98@gmail.com>
…tities Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
0e2bafd
to
3fc8810
Compare
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
3fc8810
to
0ee173b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@felixwang9817: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it: The current Redshift historical retrieval query does not support using multiple entities. This PR fixes that.
Which issue(s) this PR fixes:
Fixes #1816
Does this PR introduce a user-facing change?: