Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple entities in Redshift #1850

Merged
merged 7 commits into from
Sep 15, 2021

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: The current Redshift historical retrieval query does not support using multiple entities. This PR fixes that.

Which issue(s) this PR fixes:

Fixes #1816

Does this PR introduce a user-facing change?:

Users can now use multiple entities for historical retrieval on Redshift

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #1850 (f84fef3) into master (32d5c6c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1850      +/-   ##
==========================================
+ Coverage   84.92%   84.97%   +0.04%     
==========================================
  Files          92       92              
  Lines        7185     7202      +17     
==========================================
+ Hits         6102     6120      +18     
+ Misses       1083     1082       -1     
Flag Coverage Δ
integrationtests 84.90% <100.00%> (+0.04%) ⬆️
unittests 62.60% <12.50%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/redshift.py 84.87% <ø> (ø)
sdk/python/feast/infra/online_stores/helpers.py 86.20% <100.00%> (-0.46%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 100.00% <100.00%> (ø)
...tegration/feature_repos/universal/feature_views.py 96.66% <100.00%> (+0.23%) ⬆️
...fline_store/test_universal_historical_retrieval.py 99.18% <100.00%> (+0.04%) ⬆️
.../integration/online_store/test_universal_online.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/provider.py 90.08% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d5c6c...f84fef3. Read the comment docs.

@felixwang9817
Copy link
Collaborator Author

/kind bug

@felixwang9817 felixwang9817 force-pushed the redshift_entities branch 3 times, most recently from 86d74db to e31c7bf Compare September 14, 2021 08:02
@felixwang9817
Copy link
Collaborator Author

/retest

@felixwang9817
Copy link
Collaborator Author

/retest

1 similar comment
@felixwang9817
Copy link
Collaborator Author

/retest

…e entities

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
…ties

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
…tities

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sdk/python/feast/infra/online_stores/helpers.py Outdated Show resolved Hide resolved
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Copy link
Collaborator Author

/lgtm

@feast-ci-bot
Copy link
Collaborator

@felixwang9817: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot feast-ci-bot merged commit c7a4664 into feast-dev:master Sep 15, 2021
@felixwang9817 felixwang9817 deleted the redshift_entities branch September 15, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redshift does not support multiple entities
4 participants