Add dill to main dependencies
#1886
Conversation
`dill` is imported by `sdk/python/feast/on_demand_feature_view.py` and so is needed as a main dependency. Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
judahrand
requested review from
achals,
adchia,
felixwang9817,
tsotnet,
woop and
a team
as code owners
|
Hi @judahrand. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
=======================================
Coverage 62.30% 62.30%
=======================================
Files 96 96
Lines 7353 7353
=======================================
Hits 4581 4581
Misses 2772 2772
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
What this PR does / why we need it:
dillis imported bysdk/python/feast/on_demand_feature_view.pyandso is needed as a main dependency.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: