-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tests #1901
Cleanup tests #1901
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
New changes are detected. LGTM label has been removed. |
/kind housekeeping |
Codecov Report
@@ Coverage Diff @@
## master #1901 +/- ##
==========================================
- Coverage 83.31% 82.97% -0.35%
==========================================
Files 96 96
Lines 7482 7306 -176
==========================================
- Hits 6234 6062 -172
+ Misses 1248 1244 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What this PR does / why we need it: The universal test suite refactor made several old tests redundant. This PR removes redundant tests in
test_historical_retrieval.py
.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: