Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tests #1901

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Cleanup tests #1901

merged 5 commits into from
Sep 23, 2021

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: The universal test suite refactor made several old tests redundant. This PR removes redundant tests in test_historical_retrieval.py.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Sep 23, 2021
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@felixwang9817
Copy link
Collaborator Author

/kind housekeeping

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #1901 (d7ed40e) into master (09f525c) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1901      +/-   ##
==========================================
- Coverage   83.31%   82.97%   -0.35%     
==========================================
  Files          96       96              
  Lines        7482     7306     -176     
==========================================
- Hits         6234     6062     -172     
+ Misses       1248     1244       -4     
Flag Coverage Δ
integrationtests 74.71% <42.85%> (+0.51%) ⬆️
unittests 60.49% <85.71%> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 100.00% <ø> (ø)
sdk/python/feast/driver_test_data.py 100.00% <100.00%> (ø)
sdk/python/tests/unit/test_feature_validation.py 100.00% <100.00%> (ø)
sdk/python/feast/feature.py 72.72% <0.00%> (-1.52%) ⬇️
...python/feast/infra/offline_stores/offline_utils.py 90.10% <0.00%> (-1.10%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 83.92% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f525c...d7ed40e. Read the comment docs.

@achals achals added the lgtm label Sep 23, 2021
@feast-ci-bot feast-ci-bot merged commit dcae160 into feast-dev:master Sep 23, 2021
@felixwang9817 felixwang9817 deleted the cleanup_tests branch September 23, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants