Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect specified ValueTypes for features during materialization #1906

Merged
merged 8 commits into from
Sep 29, 2021
Merged

Respect specified ValueTypes for features during materialization #1906

merged 8 commits into from
Sep 29, 2021

Commits on Sep 25, 2021

  1. assert float feature is still float from online store 

    Signed-off-by: Jeff <jeffxl@apple.com>
    @Agent007
    Agent007 committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    2231ef4 View commit details
    Browse the repository at this point in the history

  2. ensure float features retain float type from online store 

    Floats were converted to doubles when materialized to
the online store.  There is a broader bug trend around
type conversions and this particular conversion utility
function looks like it could use some cleanup. This
commit is a quick fix.

Signed-off-by: Jeff <jeffxl@apple.com>
    @Agent007
    Agent007 committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    eb2bcfd View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. make fix more general 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    2819dd3 View commit details
    Browse the repository at this point in the history

  2. Use assertAlmostEquals 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    8d270e8 View commit details
    Browse the repository at this point in the history

  3. format 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    07a1aa2 View commit details
    Browse the repository at this point in the history

  4. Support pandas timestamps correctly 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    60574af View commit details
    Browse the repository at this point in the history

  5. Support pandas timestamps correctly 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    e13eae6 View commit details
    Browse the repository at this point in the history

  6. Correct import 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    badcdf8 View commit details
    Browse the repository at this point in the history