Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a 5 minute limit for redshift statement execution #1915

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

achals
Copy link
Member

@achals achals commented Sep 30, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1841

Does this PR introduce a user-facing change?:

Sets a 5 minute limit for redshift statement execution.

Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #1915 (6c9ddcf) into master (ce5a130) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
+ Coverage   82.85%   82.95%   +0.10%     
==========================================
  Files          96       96              
  Lines        7360     7359       -1     
==========================================
+ Hits         6098     6105       +7     
+ Misses       1262     1254       -8     
Flag Coverage Δ
integrationtests 74.38% <100.00%> (-0.24%) ⬇️
unittests 60.76% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/utils/aws_utils.py 83.03% <100.00%> (-0.90%) ⬇️
sdk/python/feast/importer.py 64.28% <0.00%> (-9.40%) ⬇️
sdk/python/feast/feature_service.py 75.34% <0.00%> (-1.29%) ⬇️
sdk/python/feast/entity.py 73.60% <0.00%> (-1.21%) ⬇️
sdk/python/feast/feature_table.py 44.89% <0.00%> (-0.38%) ⬇️
sdk/python/feast/feature_view.py 86.57% <0.00%> (-0.36%) ⬇️
sdk/python/feast/on_demand_feature_view.py 89.47% <0.00%> (-0.19%) ⬇️
sdk/python/tests/unit/test_entity.py 100.00% <0.00%> (ø)
...ion/test_cli_apply_duplicated_featureview_names.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5a130...6c9ddcf. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 189ffb0 into feast-dev:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redshift does not exit long running query
4 participants