Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging and error messages in serverless #1923

Merged
merged 8 commits into from
Oct 6, 2021

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Oct 5, 2021

What this PR does / why we need it: This PR cleans up the logging and error messages in the AWS serverless deployments code.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #1923 (b3c0832) into master (41535d0) will increase coverage by 0.05%.
The diff coverage is 32.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage   82.27%   82.32%   +0.05%     
==========================================
  Files          96       96              
  Lines        7470     7497      +27     
==========================================
+ Hits         6146     6172      +26     
- Misses       1324     1325       +1     
Flag Coverage Δ
integrationtests 73.90% <32.25%> (+0.08%) ⬆️
unittests 60.11% <32.25%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/version.py 28.57% <ø> (ø)
sdk/python/feast/infra/aws.py 41.61% <26.31%> (+0.98%) ⬆️
sdk/python/feast/cli.py 38.79% <37.50%> (-0.49%) ⬇️
sdk/python/feast/errors.py 70.07% <50.00%> (ø)
sdk/python/feast/on_demand_feature_view.py 88.70% <0.00%> (-0.77%) ⬇️
sdk/python/feast/feature_view.py 86.25% <0.00%> (-0.33%) ⬇️
.../integration/online_store/test_universal_online.py 100.00% <0.00%> (ø)
sdk/python/feast/feature_store.py 94.33% <0.00%> (+0.53%) ⬆️
sdk/python/feast/infra/utils/aws_utils.py 71.73% <0.00%> (+0.72%) ⬆️
sdk/python/feast/feature_service.py 79.41% <0.00%> (+4.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41535d0...b3c0832. Read the comment docs.

sdk/python/feast/constants.py Outdated Show resolved Hide resolved
sdk/python/feast/infra/aws.py Outdated Show resolved Hide resolved
…st CLI

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia adchia changed the title Refactor serverless Refactor logging and error messages in serverless Oct 6, 2021
@felixwang9817
Copy link
Collaborator Author

/kind housekeeping

@feast-ci-bot feast-ci-bot merged commit a5b8c26 into feast-dev:master Oct 6, 2021
@felixwang9817 felixwang9817 deleted the refactor_serverless branch October 6, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants