Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for feature server Docker image #1925

Merged

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Oct 6, 2021

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: This PR is adding CI for building the feature server Docker image. Since the workflow cannot be tested in this PR, I will iterate on the workflow in later PRs.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #1925 (481d5c4) into master (b1ccf8d) will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
- Coverage   82.34%   81.96%   -0.39%     
==========================================
  Files          96       96              
  Lines        7490     7557      +67     
==========================================
+ Hits         6168     6194      +26     
- Misses       1322     1363      +41     
Flag Coverage Δ
integrationtests 73.63% <ø> (-0.29%) ⬇️
unittests 59.93% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/unit/test_feature_validation.py 83.33% <0.00%> (-16.67%) ⬇️
sdk/python/feast/flags_helper.py 89.47% <0.00%> (-4.65%) ⬇️
sdk/python/feast/on_demand_feature_view.py 86.15% <0.00%> (-2.56%) ⬇️
sdk/python/feast/feature_view.py 84.33% <0.00%> (-1.92%) ⬇️
sdk/python/feast/infra/aws.py 39.67% <0.00%> (-0.96%) ⬇️
sdk/python/feast/infra/provider.py 90.00% <0.00%> (-0.68%) ⬇️
sdk/python/feast/cli.py 38.69% <0.00%> (-0.58%) ⬇️
sdk/python/feast/feature_store.py 94.17% <0.00%> (-0.17%) ⬇️
sdk/python/feast/errors.py 70.00% <0.00%> (-0.08%) ⬇️
sdk/python/feast/flags.py 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ccf8d...481d5c4. Read the comment docs.

@felixwang9817 felixwang9817 force-pushed the feature_server_versioning branch 2 times, most recently from 6d4d548 to 0f02210 Compare October 6, 2021 20:40
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Copy link
Collaborator Author

/kind housekeeping

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Oct 6, 2021

@felixwang9817 you can also use your own repo if you just want to iterate quickly without actually going through a PR flow.

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Oct 8, 2021
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot added size/S and removed size/M labels Oct 8, 2021
@achals achals added the lgtm label Oct 8, 2021
@achals
Copy link
Member

achals commented Oct 8, 2021

Lgtm. Retried integration tests.

@feast-ci-bot feast-ci-bot merged commit 1e4caea into feast-dev:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants