Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows registering of features in request data as RequestFeatureView. Refactors common logic into a BaseFeatureView class #1931

Merged
merged 26 commits into from
Oct 15, 2021
Merged

Allows registering of features in request data as RequestFeatureView. Refactors common logic into a BaseFeatureView class #1931

merged 26 commits into from
Oct 15, 2021

Commits on Oct 15, 2021

  1. Initial implementation of Request Feature View without validation, wi… 

    …th some refactoring of feature views

Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    1f5c734 View commit details
    Browse the repository at this point in the history

  2. Refactor constructor in base class 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    7d20750 View commit details
    Browse the repository at this point in the history

  3. Refactor to have constructor init in base class 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    a8669fd View commit details
    Browse the repository at this point in the history

  4. Moving copy methods into base class 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5455713 View commit details
    Browse the repository at this point in the history

  5. lint 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4a328bd View commit details
    Browse the repository at this point in the history

  6. Implement request feature view validation in historical and online re… 

    …trieval

Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    9f92ba4 View commit details
    Browse the repository at this point in the history

  7. Add tests for request_fv 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    d3da295 View commit details
    Browse the repository at this point in the history

  8. Update CLI to understand request feature views 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    d3f088b View commit details
    Browse the repository at this point in the history

  9. Fix error to be more generic and apply to all feature views 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4fbcf90 View commit details
    Browse the repository at this point in the history

  10. Add type of feature view to feature view list command 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    af14bec View commit details
    Browse the repository at this point in the history

  11. Add type of feature view to feature view list command 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4dc2f4b View commit details
    Browse the repository at this point in the history

  12. Lint imports 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    29ece3a View commit details
    Browse the repository at this point in the history

  13. Fix new lines and nits 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    325aab5 View commit details
    Browse the repository at this point in the history

  14. Fix repo apply bug 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    33abe41 View commit details
    Browse the repository at this point in the history

  15. Fix comments 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    1ad1f5e View commit details
    Browse the repository at this point in the history

  16. format 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    d025b2c View commit details
    Browse the repository at this point in the history

  17. fix test 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    eae793c View commit details
    Browse the repository at this point in the history

  18. reverse naming 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    53d6891 View commit details
    Browse the repository at this point in the history

  19. reverse naming 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    8a3738b View commit details
    Browse the repository at this point in the history

  20. reverse naming 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    f5ffed9 View commit details
    Browse the repository at this point in the history

  21. Add back to cli 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    86a2a0d View commit details
    Browse the repository at this point in the history

  22. Comments 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    39d7e0d View commit details
    Browse the repository at this point in the history

  23. Lint 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    9570da6 View commit details
    Browse the repository at this point in the history

  24. Remove extra data in response 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5c4ef6a View commit details
    Browse the repository at this point in the history

  25. revert change 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    66c1298 View commit details
    Browse the repository at this point in the history

  26. revert change 

    Signed-off-by: Danny Chiao <danny@tecton.ai>
    @adchia
    adchia committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    c64a452 View commit details
    Browse the repository at this point in the history