Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IntegrationTestRepoConfig class to another module #1962

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: In order for plugin repos to override FULL_REPO_CONFIGS, they must import the IntegrationTestRepoConfig class. However, if the class remains in repo_configuration.py, it will automatically trigger FULL_REPO_CONFIGS to be computed. By moving the class to another file, we avoid this circular logic.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817
Copy link
Collaborator Author

/kind bug

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #1962 (b43ccef) into master (3b5ea8f) will decrease coverage by 7.66%.
The diff coverage is 100.00%.

❗ Current head b43ccef differs from pull request most recent head 8f6df52. Consider uploading reports for the commit 8f6df52 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
- Coverage   81.97%   74.31%   -7.67%     
==========================================
  Files          99       98       -1     
  Lines        7922     7867      -55     
==========================================
- Hits         6494     5846     -648     
- Misses       1428     2021     +593     
Flag Coverage Δ
integrationtests 74.31% <100.00%> (+0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tion/feature_repos/integration_test_repo_config.py 100.00% <100.00%> (ø)
...ts/integration/feature_repos/repo_configuration.py 92.40% <100.00%> (-0.78%) ⬇️
...ion/test_cli_apply_duplicated_featureview_names.py 14.54% <0.00%> (-85.46%) ⬇️
...n/tests/integration/registration/test_cli_chdir.py 18.51% <0.00%> (-81.49%) ⬇️
.../python/tests/integration/scaffolding/test_init.py 18.91% <0.00%> (-81.09%) ⬇️
sdk/python/tests/unit/test_proto_json.py 21.05% <0.00%> (-78.95%) ⬇️
sdk/python/feast/proto_json.py 18.18% <0.00%> (-77.28%) ⬇️
sdk/python/tests/doctest/test_all.py 16.36% <0.00%> (-76.37%) ⬇️
...ts/integration/scaffolding/test_repo_operations.py 24.07% <0.00%> (-75.93%) ⬇️
...n/tests/integration/online_store/test_e2e_local.py 24.48% <0.00%> (-75.52%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5ea8f...8f6df52. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b0635c3 into feast-dev:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants