Delete keys from Redis when tearing down online store #1965
Conversation
achals
requested review from
adchia,
felixwang9817,
tsotnet,
woop and
a team
as code owners
Signed-off-by: Achal Shah <achals@gmail.com>
achals
force-pushed
the
achal/delete-redis-keys
branch
from
b0da50a to
57adc31
Compare
Codecov Report
@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
+ Coverage 81.98% 82.03% +0.04%
==========================================
Files 100 100
Lines 7926 7948 +22
==========================================
+ Hits 6498 6520 +22
Misses 1428 1428
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
| client = self._get_client(config.online_store) | ||
| deleted_count = 0 | ||
| for table in tables_to_delete: | ||
| pipline = client.pipeline() |
| client = self._get_client(config.online_store) | ||
| deleted_count = 0 | ||
| for table in tables: | ||
| pipline = client.pipeline() |
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind bug |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
When you run
feast teardownon a feast project that uses redis as the online store, it leaves behind all the keys that're written into redis.This is bad and is an obvious leak of memory/resources. In contrast, in dynamo and datastore, the tables and values are cleaned up.
Does this PR introduce a user-facing change?: