Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Feast CLI / python SDK documentation #199

Merged
merged 21 commits into from
May 28, 2019
Merged

Add Feast CLI / python SDK documentation #199

merged 21 commits into from
May 28, 2019

Conversation

romanwozniak
Copy link
Collaborator

In this PR:

  • Removed all mentions of granularity from the documentation / proto (because it was removed from the codebase in Remove feature "granularity" and relegate to metadata #17)
  • Picked up some WIP Feast CLI docs from @thirteen37 and updated them with information about import job spec registration
  • Added a quick start guide for feast python SDK (how to install it, register entity/features, ingest features into feast, retrieve training/serving data)

thirteen37 and others added 13 commits May 2, 2019 18:13
@thirteen37
Storage registration quickstart
0a28e5c 
For Feast admins.
@thirteen37
Minimum requirements for Feast GKE cluster
9620262
@thirteen37
Storage specs quickstart for admins
14382b2
@thirteen37
WIP - End user quickstart
2dd62bd
@thirteen37
Example spec files
a3b29b0
@thirteen37
Updated protobuf generated files
d3df0b9 
Using vendored protobuf, here are the new generated files
@romanwozniak
Merge branch 'upstream-master' into end-user-quickstart
99dc4e4 
# Conflicts:
#	charts/feast/values.yaml
#	docs/install.md
#	protos/generated/go/feast/core/CoreService.pb.go
#	protos/generated/go/feast/core/DatasetService.pb.go
#	protos/generated/go/feast/core/JobService.pb.go
#	protos/generated/go/feast/core/UIService.pb.go
#	protos/generated/go/feast/serving/Serving.pb.go
#	protos/generated/go/feast/specs/EntitySpec.pb.go
#	protos/generated/go/feast/specs/FeatureGroupSpec.pb.go
#	protos/generated/go/feast/specs/FeatureSpec.pb.go
#	protos/generated/go/feast/specs/ImportJobSpecs.pb.go
#	protos/generated/go/feast/specs/ImportSpec.pb.go
#	protos/generated/go/feast/specs/StorageSpec.pb.go
#	protos/generated/go/feast/storage/BigTable.pb.go
#	protos/generated/go/feast/storage/Redis.pb.go
#	protos/generated/go/feast/types/Feature.pb.go
#	protos/generated/go/feast/types/FeatureRow.pb.go
#	protos/generated/go/feast/types/FeatureRowExtended.pb.go
#	protos/generated/go/feast/types/Value.pb.go
@romanwozniak
Removed references to granularity from the docs
49d6979
@romanwozniak
Removed references to granularity from the docs
1e57da0
@romanwozniak
Added info on how to register features and run an import job from CLI;
daee329 
other fixes in the docs;
@romanwozniak
fix typos
ceb3198
@romanwozniak
- WIP on python SDK quickstart documentation
a748191
@romanwozniak
- add training/serving data retrieval sections
2e55d1a
@feast-ci-bot
Copy link
Collaborator

Hi @romanwozniak. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pradithya
Copy link
Collaborator

/ok-to-test

zhilingc
zhilingc reviewed May 25, 2019
View reviewed changes
docs/specs.md Outdated Show resolved Hide resolved
examples/values.yaml Show resolved Hide resolved
@davidheryanto
Update default values.yaml for Feast
6a8766a 
Use Feast image tag 0.1.1 because it fixes some templating in BigQuery
https://github.com/gojek/feast/releases/tag/v0.1.1
@zhilingc
Copy link
Collaborator

/lgtm

Thanks Roman!

@feast-ci-bot feast-ci-bot removed the lgtm label May 27, 2019
@davidheryanto
Copy link
Collaborator

/lgtm

@zhilingc
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: romanwozniak, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 1bdbfb5 into feast-dev:master May 28, 2019
@romanwozniak romanwozniak deleted the end-user-quickstart branch May 28, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhilingc zhilingc zhilingc left review comments

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@pradithya pradithya Awaiting requested review from pradithya

@thirteen37 thirteen37 Awaiting requested review from thirteen37

@tims tims Awaiting requested review from tims

@woop woop Awaiting requested review from woop

Assignees

@davidheryanto davidheryanto

@zhilingc zhilingc

Labels
approved lgtm ok-to-test size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@romanwozniak @feast-ci-bot @pradithya @zhilingc @davidheryanto @thirteen37