-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix protobuf version conflict in [gcp] and [ci] packages #1992
Fix protobuf version conflict in [gcp] and [ci] packages #1992
Conversation
Signed-off-by: Yusuke Nishioka <yusuke.nishioka.0713@gmail.com>
Hi @ysk24ok. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1992 +/- ##
=======================================
Coverage 82.15% 82.15%
=======================================
Files 101 101
Lines 8074 8074
=======================================
Hits 6633 6633
Misses 1441 1441
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdk/python/setup.py
Outdated
@@ -66,6 +66,9 @@ | |||
] | |||
|
|||
GCP_REQUIRED = [ | |||
# proto-plus>=1.19.7 requires protobuf>=3.19.0 | |||
# which conflicts with the version required by google-api-core[grpc] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While those comments are really useful in the PR, it should be removed in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted by 42d6f6f.
Signed-off-by: Yusuke Nishioka <yusuke.nishioka.0713@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MattDelac, ysk24ok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yusuke Nishioka yusuke.nishioka.0713@gmail.com
What this PR does / why we need it:
proto-plus==1.19.7
requiresprotobuf>=3.19.0
, which conflicts with the version required bygoogle-api-core[grpc]
.Also,
setup_requires
tries to install the latest version ofmypy-protobuf
because the version is not specified and it requiresprotobuf>=3.18.0
.The error log is like this:
So I've fixed
proto-plus
version to<1.19.7
in[gcp]
and[ci]
packages, andmypy-protobuf
insetup_requires
to==1.*
.We can check the installation succeeds by
pipenv install -e "sdk/python[gcp]"
andpipenv install -e "sdk/python[ci]"
Which issue(s) this PR fixes:
refs #1912 (comment)
IMO, closing #1912 should be done after the new version is released and we confirms that the installation succeeds.
Does this PR introduce a user-facing change?: