Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tensorflow-metadata folders #2038

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

casassg
Copy link
Contributor

@casassg casassg commented Nov 15, 2021

Instead of sourcing tensorflow-metadata files in the sdk, we add a dependency on tensorflow-metadata library.

Currently feast python adds tensorflow_metadata namespace. This causes pip to overwrite the tensorflow-metadata library if installed after.

So instead of doing this, we can just add a dependency on tensorflow-metadata.

This PR is a proposal to fix the issue detected in #2035

Switch to use tensorflow-metadata requirement instead of sourcing compiled tensorflow-metadata in the sdk.

@feast-ci-bot
Copy link
Collaborator

Hi @casassg. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Nov 15, 2021

Thanks @casassg!

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #2038 (366b2fc) into master (d0a7863) will increase coverage by 23.40%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2038       +/-   ##
===========================================
+ Coverage   60.01%   83.42%   +23.40%     
===========================================
  Files         103      100        -3     
  Lines        8523     8028      -495     
===========================================
+ Hits         5115     6697     +1582     
+ Misses       3408     1331     -2077     
Flag Coverage Δ
integrationtests 74.17% <ø> (?)
unittests 57.54% <ø> (-2.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/online_response.py 87.71% <0.00%> (+1.75%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 96.77% <0.00%> (+2.15%) ⬆️
sdk/python/feast/feature.py 72.72% <0.00%> (+3.03%) ⬆️
sdk/python/feast/infra/provider.py 91.73% <0.00%> (+4.95%) ⬆️
sdk/python/feast/errors.py 70.00% <0.00%> (+5.00%) ⬆️
sdk/python/feast/data_source.py 61.29% <0.00%> (+6.45%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 96.80% <0.00%> (+8.00%) ⬆️
sdk/python/feast/feature_view.py 88.05% <0.00%> (+10.69%) ⬆️
sdk/python/feast/infra/passthrough_provider.py 100.00% <0.00%> (+11.11%) ⬆️
sdk/python/feast/repo_config.py 87.00% <0.00%> (+11.86%) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a7863...366b2fc. Read the comment docs.

sdk/python/setup.py Outdated Show resolved Hide resolved
Signed-off-by: Gerard Casas Saez <gcasassaez@twitter.com>
Signed-off-by: Gerard Casas Saez <gcasassaez@twitter.com>
@casassg
Copy link
Contributor Author

casassg commented Nov 15, 2021

(rebased for signoff)

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, casassg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Nov 15, 2021

/kind housekeeping

@feast-ci-bot feast-ci-bot merged commit dc46a96 into feast-dev:master Nov 15, 2021
@casassg
Copy link
Contributor Author

casassg commented Nov 15, 2021

(is there a schedule for when this may be released? Mostly want to use this for tfx-addons project :D )

@casassg casassg deleted the gcasassaez/rm-tf-metadata branch November 15, 2021 21:51
@achals
Copy link
Member

achals commented Nov 15, 2021

@casassg @adchia can comment but I believe we're planning on cutting a new release in a the coming couple of weeks.

@casassg
Copy link
Contributor Author

casassg commented Nov 15, 2021

Sg! Will wait for confirmation. Would be nice otherwise if we can backport this to 0.15 as a patch release given that this is mostly a "bug" fix (I understand it's not, but it should not modify behaviour as it effectively should be the same)

@adchia
Copy link
Collaborator

adchia commented Nov 15, 2021

There's likely some patch release we could sneak in relatively soon since we do have several issues we want to resolve.

ArrichM pushed a commit to ArrichM/feast that referenced this pull request Nov 16, 2021
* remove tensorflow-metadata folders

Signed-off-by: Gerard Casas Saez <gcasassaez@twitter.com>

* add missing comma

Signed-off-by: Gerard Casas Saez <gcasassaez@twitter.com>
Signed-off-by: ArrichM <maximilianjakob.arrich@student.unisg.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants