-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tensorflow-metadata folders #2038
Remove tensorflow-metadata folders #2038
Conversation
Hi @casassg. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @casassg! |
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
===========================================
+ Coverage 60.01% 83.42% +23.40%
===========================================
Files 103 100 -3
Lines 8523 8028 -495
===========================================
+ Hits 5115 6697 +1582
+ Misses 3408 1331 -2077
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Gerard Casas Saez <gcasassaez@twitter.com>
Signed-off-by: Gerard Casas Saez <gcasassaez@twitter.com>
13b0bdb
to
366b2fc
Compare
(rebased for signoff) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, casassg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind housekeeping |
(is there a schedule for when this may be released? Mostly want to use this for tfx-addons project :D ) |
Sg! Will wait for confirmation. Would be nice otherwise if we can backport this to 0.15 as a patch release given that this is mostly a "bug" fix (I understand it's not, but it should not modify behaviour as it effectively should be the same) |
There's likely some patch release we could sneak in relatively soon since we do have several issues we want to resolve. |
* remove tensorflow-metadata folders Signed-off-by: Gerard Casas Saez <gcasassaez@twitter.com> * add missing comma Signed-off-by: Gerard Casas Saez <gcasassaez@twitter.com> Signed-off-by: ArrichM <maximilianjakob.arrich@student.unisg.ch>
Instead of sourcing tensorflow-metadata files in the sdk, we add a dependency on tensorflow-metadata library.
Currently feast python adds tensorflow_metadata namespace. This causes pip to overwrite the tensorflow-metadata library if installed after.
So instead of doing this, we can just add a dependency on tensorflow-metadata.
This PR is a proposal to fix the issue detected in #2035