Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up references to core in github workflow #2042

Closed
wants to merge 1 commit into from

Conversation

achals
Copy link
Member

@achals achals commented Nov 15, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

There's some references to core (which has been removed in #2029) in github actions which causes them to fail. The old references need to be cleaned up.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #2042 (2d8037a) into master (dc46a96) will decrease coverage by 26.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2042       +/-   ##
===========================================
- Coverage   83.70%   57.54%   -26.16%     
===========================================
  Files         100      100               
  Lines        8028     8028               
===========================================
- Hits         6720     4620     -2100     
- Misses       1308     3408     +2100     
Flag Coverage Δ
integrationtests ?
unittests 57.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 15.34% <0.00%> (-82.80%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.29% <0.00%> (-80.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 35.00% <0.00%> (-65.00%) ⬇️
...s/integration/registration/test_universal_types.py 36.73% <0.00%> (-63.27%) ⬇️
...istration/test_universal_odfv_feature_inference.py 38.29% <0.00%> (-61.71%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc46a96...2d8037a. Read the comment docs.

@achals
Copy link
Member Author

achals commented Nov 16, 2021

/kind bug

@felixwang9817 felixwang9817 removed their assignment Nov 18, 2021
@achals
Copy link
Member Author

achals commented Nov 18, 2021

Closed by #2059.

@achals achals closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants