Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected feature view deletion when applying edited odfv #2054

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Fix unexpected feature view deletion when applying edited odfv #2054

merged 2 commits into from
Nov 17, 2021

Commits on Nov 17, 2021

  1. Delete feature-view proto from correct container when an on-demand-fe… 

    …ature-view has changed.

Signed-off-by: ArrichM <maximilianjakob.arrich@student.unisg.ch>
    @ArrichM
    ArrichM committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    5084ef2 View commit details
    Browse the repository at this point in the history

  2. Add test case in test_registry.py to check if regular feature views a… 

    …re not interfered with when modifying on-demand-feature-views.

Signed-off-by: ArrichM <maximilianjakob.arrich@student.unisg.ch>
    @ArrichM
    ArrichM committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    6f63453 View commit details
    Browse the repository at this point in the history