-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix java_release workflow by removing step without users/with #2067
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,6 @@ | |
import com.google.cloud.storage.StorageOptions; | ||
import feast.serving.registry.*; | ||
import java.net.URI; | ||
import java.nio.file.Paths; | ||
import java.util.Optional; | ||
import org.springframework.context.ApplicationContext; | ||
import org.springframework.context.annotation.Bean; | ||
|
@@ -59,7 +58,7 @@ RegistryFile registryFile(FeastProperties feastProperties, ApplicationContext co | |
return new S3RegistryFile(context.getBean(AmazonS3.class), registryPath); | ||
case "": | ||
case "file": | ||
return new LocalRegistryFile(Paths.get(registryPath)); | ||
return new LocalRegistryFile(registryPath); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you explain this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Trying to address this error in java unit tests:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, this is bug from my PR #2043, have no idea how it passed tests |
||
default: | ||
throw new RuntimeException("Registry storage %s is unsupported"); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the point to duplicate env here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bare
env
version step up above is breaking the workflow: https://github.com/feast-dev/feast/actions/workflows/java_release.yml