-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attempt to compute ODFVs when there are no ODFVs #2090
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2090 +/- ##
===========================================
- Coverage 83.44% 58.09% -25.36%
===========================================
Files 100 100
Lines 8077 8077
===========================================
- Hits 6740 4692 -2048
- Misses 1337 3385 +2048
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
e10337b
to
ee1c2e2
Compare
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: This PR ensures that we do not attempt to compute ODFVs in
RetrievalJobs
when there are no ODFVs.Which issue(s) this PR fixes:
Fixes #2072
Does this PR introduce a user-facing change?: