Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in feature retrieval doc #2092

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

olivierlabreche
Copy link
Contributor

@olivierlabreche olivierlabreche commented Nov 25, 2021

What this PR does / why we need it:
Fix a typo (I think) in feature retrieval doc. I am not sure why we talk about "entity timestamp" when we refer to "event timestamp" everywhere else in the paragraph.

Which issue(s) this PR fixes:
N/A

Does this PR introduce a user-facing change?:
NONE

Fix typo in feature retrieval doc

@feast-ci-bot
Copy link
Collaborator

Hi @olivierlabreche. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #2092 (09c866d) into master (54d0f3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2092   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files         100      100           
  Lines        8077     8077           
=======================================
  Hits         6740     6740           
  Misses       1337     1337           
Flag Coverage Δ
integrationtests 73.87% <ø> (ø)
unittests 58.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d0f3a...09c866d. Read the comment docs.

@felixwang9817
Copy link
Collaborator

Hey @olivierlabreche, thanks a lot for the PR! We require that all commits be signed - would you mind rebasing your changes and signing all of your commits? Thanks!

Signed-off-by: Olivier Labreche <olivier.labreche@shopify.com>
@olivierlabreche
Copy link
Contributor Author

Hey @olivierlabreche, thanks a lot for the PR! We require that all commits be signed - would you mind rebasing your changes and signing all of your commits? Thanks!

Sign-off added. Thanks.

@olivierlabreche
Copy link
Contributor Author

/assign @felixwang9817

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817, olivierlabreche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants