-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requested_features is passed to online_read from passthrough_provider #2107
requested_features is passed to online_read from passthrough_provider #2107
Conversation
Hi @aurobindoc. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Aurobindo Mondal <aurobindoc1991@gmail.com>
e8739db
to
b5202df
Compare
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
- Coverage 83.53% 83.51% -0.02%
==========================================
Files 100 100
Lines 8088 8088
==========================================
- Hits 6756 6755 -1
- Misses 1332 1333 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aurobindoc, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
OnlineStore.online_read()
has a parameterrequested_features
. Similarly,PassthroughProvider.online_read()
also has a parameterrequested_features
.PassthroughProvider.online_read()
callsOnlineStore.online_read()
but doesn't pass on therequested_features
variable.In this PR, the
requested_features
variable is passed on toOnlineStore.online_read()
Which issue(s) this PR fixes:
Fixes #2106
Does this PR introduce a user-facing change?:
None