Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helm chart back to main repo #2113

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Dec 6, 2021

Signed-off-by: pyalex moskalenko.alexey@gmail.com

What this PR does / why we need it:

Helm chart is part of main repo again. It can be used to install java feature server together with transformation service on Kubernetes.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #2113 (25e2a51) into master (5d9e5f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2113   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files         100      100           
  Lines        8088     8088           
=======================================
  Hits         4691     4691           
  Misses       3397     3397           
Flag Coverage Δ
unittests 57.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9e5f7...25e2a51. Read the comment docs.

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia adchia merged commit 5826a9d into feast-dev:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants