-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that universal CLI test tears down infrastructure #2151
Ensure that universal CLI test tears down infrastructure #2151
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2151 +/- ##
===========================================
- Coverage 84.60% 58.60% -26.01%
===========================================
Files 101 101
Lines 7966 7968 +2
===========================================
- Hits 6740 4670 -2070
- Misses 1226 3298 +2072
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: Recently we have been leaking DynamoDB tables. Upon closer inspection, I noticed that tests often leak
test_universal_cli
tables. This PR aims to ensure that those tables are always torn down.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: