Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InfraDiff class for feast plan #2190

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR adds the InfraDiff class and adds support for Infra objects to the Registry.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #2190 (5a2905a) into master (d447db2) will decrease coverage by 0.07%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2190      +/-   ##
==========================================
- Coverage   84.61%   84.53%   -0.08%     
==========================================
  Files         102      104       +2     
  Lines        8207     8239      +32     
==========================================
+ Hits         6944     6965      +21     
- Misses       1263     1274      +11     
Flag Coverage Δ
integrationtests 74.24% <69.56%> (-0.35%) ⬇️
unittests 59.02% <77.27%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/registry.py 85.18% <30.00%> (-1.93%) ⬇️
sdk/python/feast/diff/infra_diff.py 85.00% <85.00%> (ø)
sdk/python/feast/diff/FcoDiff.py 88.46% <100.00%> (-2.02%) ⬇️
sdk/python/feast/diff/utils.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/utils/aws_utils.py 85.50% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d447db2...5a2905a. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the commit message/PR title should be more descriptive

sdk/python/feast/diff/utils.py Outdated Show resolved Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 changed the title Feast plan Add InfraDiff class Jan 5, 2022
@felixwang9817 felixwang9817 changed the title Add InfraDiff class Add InfraDiff class for feast plan Jan 5, 2022
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also print out what feast plan produces when infra is changed in the PR description?

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator Author

Can you also print out what feast plan produces when infra is changed in the PR description?

this PR doesn't actually change the output of feast plan

@adchia
Copy link
Collaborator

adchia commented Jan 5, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit 6c09bc4 into feast-dev:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants