-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InfraDiff class for feast plan #2190
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
- Coverage 84.61% 84.53% -0.08%
==========================================
Files 102 104 +2
Lines 8207 8239 +32
==========================================
+ Hits 6944 6965 +21
- Misses 1263 1274 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the commit message/PR title should be more descriptive
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also print out what feast plan
produces when infra is changed in the PR description?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this PR doesn't actually change the output of |
/lgtm |
What this PR does / why we need it: This PR adds the
InfraDiff
class and adds support forInfra
objects to theRegistry
.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: