Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement diff_infra_protos method for feast plan #2204

Merged

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR implements the diff_infra_protos, which will compute the difference between two InfraProto objects, for feast plan.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #2204 (31d01b5) into master (b4d12bd) will decrease coverage by 24.80%.
The diff coverage is 91.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2204       +/-   ##
===========================================
- Coverage   84.46%   59.66%   -24.81%     
===========================================
  Files         104      105        +1     
  Lines        8247     8387      +140     
===========================================
- Hits         6966     5004     -1962     
- Misses       1281     3383     +2102     
Flag Coverage Δ
integrationtests ?
unittests 59.66% <91.90%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/sqlite.py 85.59% <44.44%> (-2.24%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 40.19% <55.55%> (-42.81%) ⬇️
sdk/python/feast/infra/infra_object.py 71.73% <88.88%> (+14.23%) ⬆️
sdk/python/feast/diff/infra_diff.py 96.82% <100.00%> (+11.82%) ⬆️
sdk/python/feast/infra/online_stores/dynamodb.py 42.64% <100.00%> (-37.81%) ⬇️
sdk/python/tests/unit/diff/test_infra_diff.py 100.00% <100.00%> (ø)
.../integration/online_store/test_universal_online.py 15.34% <0.00%> (-82.80%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.18% <0.00%> (-80.82%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d12bd...31d01b5. Read the comment docs.

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Jan 10, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit d241a84 into feast-dev:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants