-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement diff_infra_protos method for feast plan #2204
Implement diff_infra_protos method for feast plan #2204
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2204 +/- ##
===========================================
- Coverage 84.46% 59.66% -24.81%
===========================================
Files 104 105 +1
Lines 8247 8387 +140
===========================================
- Hits 6966 5004 -1962
- Misses 1281 3383 +2102
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it: This PR implements the
diff_infra_protos
, which will compute the difference between twoInfraProto
objects, forfeast plan
.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: