-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a local feature server test #2217
Adding a local feature server test #2217
Conversation
Signed-off-by: Danny Chiao <danny@tecton.ai>
d08948a
to
a90fd40
Compare
Codecov Report
@@ Coverage Diff @@
## master #2217 +/- ##
==========================================
- Coverage 59.83% 59.75% -0.09%
==========================================
Files 105 105
Lines 8453 8480 +27
==========================================
+ Hits 5058 5067 +9
- Misses 3395 3413 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Danny Chiao <danny@tecton.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it'll make server development way easier! Awesome.
Test failures look like the class AWS failures.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
We've run into issues debugging the lambda test, so introducing a local feature server that is instantiated on tests that have python_feature_server=True on a local provider.
This also logs the stack trace on the feature server. This was useful in debugging #2202
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: