Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a local feature server test #2217

Merged
merged 8 commits into from
Jan 18, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Jan 18, 2022

What this PR does / why we need it:
We've run into issues debugging the lambda test, so introducing a local feature server that is instantiated on tests that have python_feature_server=True on a local provider.

This also logs the stack trace on the feature server. This was useful in debugging #2202

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #2217 (d125103) into master (1b98ec9) will decrease coverage by 0.08%.
The diff coverage is 30.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2217      +/-   ##
==========================================
- Coverage   59.83%   59.75%   -0.09%     
==========================================
  Files         105      105              
  Lines        8453     8480      +27     
==========================================
+ Hits         5058     5067       +9     
- Misses       3395     3413      +18     
Flag Coverage Δ
unittests 59.75% <30.30%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tegration/feature_repos/universal/feature_views.py 36.66% <ø> (ø)
.../integration/online_store/test_universal_online.py 15.20% <0.00%> (-0.15%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 45.19% <30.76%> (-1.55%) ⬇️
sdk/python/tests/conftest.py 59.40% <33.33%> (-3.52%) ⬇️
sdk/python/feast/feature_server.py 32.50% <50.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b98ec9...d125103. Read the comment docs.

Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Member

@judahrand judahrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it'll make server development way easier! Awesome.

Test failures look like the class AWS failures.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@judahrand
Copy link
Member

/lgtm

@feast-ci-bot feast-ci-bot merged commit f32b4f4 into feast-dev:master Jan 18, 2022
@adchia adchia deleted the local-feature-server-test branch March 4, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants