Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish renamed java packages to maven central (via Sonatype) #2225

Merged
merged 5 commits into from
Jan 20, 2022

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Jan 19, 2022

What this PR does / why we need it:

Since we cannot remove artifacts from maven central this PR proposes to rename feast-sdk and datatypes-java artifacts into feast-serving-client and feast-datatypes to avoid conflicts with higher versions of artifacts that were already uploaded.

This PR also cleans up global dependencies (spring is removed completely) and refactors projects structure to avoid publishing unnecessary artifacts (like common or parent).

Which issue(s) this PR fixes:

Fixes #2218

Does this PR introduce a user-facing change?:

none

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
java/datatypes/java/pom.xml Outdated Show resolved Hide resolved
java/sdk/java/pom.xml Outdated Show resolved Hide resolved
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #2225 (309d5d0) into master (1f3a595) will decrease coverage by 25.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2225       +/-   ##
===========================================
- Coverage   84.98%   59.72%   -25.26%     
===========================================
  Files         105      105               
  Lines        8496     8496               
===========================================
- Hits         7220     5074     -2146     
- Misses       1276     3422     +2146     
Flag Coverage Δ
integrationtests ?
unittests 59.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
.../integration/online_store/test_universal_online.py 15.20% <0.00%> (-82.03%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.18% <0.00%> (-80.82%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 35.00% <0.00%> (-65.00%) ⬇️
...s/integration/registration/test_universal_types.py 36.12% <0.00%> (-63.88%) ⬇️
...istration/test_universal_odfv_feature_inference.py 38.29% <0.00%> (-61.71%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3a595...309d5d0. Read the comment docs.

@pyalex pyalex removed the needs-kind label Jan 20, 2022
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 428c145 into feast-dev:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datatypes-java maven repo out of date
4 participants