-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Redshift data creator #2242
Fix Redshift data creator #2242
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2242 +/- ##
===========================================
- Coverage 85.43% 60.11% -25.32%
===========================================
Files 108 108
Lines 9021 9027 +6
===========================================
- Hits 7707 5427 -2280
- Misses 1314 3600 +2286
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Oh! That's a tricky little bug that is! 😮 Thanks for driving this @felixwang9817 !! |
What this PR does / why we need it: This PR fixes the root cause of several recent failures with AWS integration tests on Github. The issue came from the
test_entity_inference_types_match
test intest_universal_types.py
, and occurred since the data creator attempted to upload a table to Redshift with a table name of >127 characters. Since Redshift truncates table names to 127 characters, this ensured that subsequent attempts to reference the table would fail, causing the test to fail. Moreover, since PR tests include extra information in the table name, this bug was not reproducible through local testing.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: