Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redshift data creator #2242

Merged

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Jan 27, 2022

What this PR does / why we need it: This PR fixes the root cause of several recent failures with AWS integration tests on Github. The issue came from the test_entity_inference_types_match test in test_universal_types.py, and occurred since the data creator attempted to upload a table to Redshift with a table name of >127 characters. Since Redshift truncates table names to 127 characters, this ensured that subsequent attempts to reference the table would fail, causing the test to fail. Moreover, since PR tests include extra information in the table name, this bug was not reproducible through local testing.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #2242 (b400483) into master (88fac8b) will decrease coverage by 25.31%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2242       +/-   ##
===========================================
- Coverage   85.43%   60.11%   -25.32%     
===========================================
  Files         108      108               
  Lines        9021     9027        +6     
===========================================
- Hits         7707     5427     -2280     
- Misses       1314     3600     +2286     
Flag Coverage Δ
integrationtests ?
unittests 60.11% <44.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 45.71% <0.00%> (-48.58%) ⬇️
.../python/tests/integration/registration/test_cli.py 55.78% <0.00%> (-43.54%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 30.49% <50.00%> (-55.02%) ⬇️
sdk/python/feast/errors.py 67.36% <66.66%> (-3.57%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
.../integration/online_store/test_universal_online.py 15.20% <0.00%> (-82.49%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.71% <0.00%> (-76.29%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fac8b...b400483. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Jan 27, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit 46c4722 into feast-dev:master Jan 27, 2022
@judahrand
Copy link
Member

Oh! That's a tricky little bug that is! 😮 Thanks for driving this @felixwang9817 !!

@adchia adchia mentioned this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants