Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate Python feature server #2263

Merged
merged 6 commits into from
Feb 2, 2022

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR graduates the Python feature server from alpha status by removing the alpha flag check and modifying the docs. It also deletes some useless doc files.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #2263 (7327b1c) into master (7c53177) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
+ Coverage   85.42%   85.46%   +0.04%     
==========================================
  Files         112      112              
  Lines        9593     9586       -7     
==========================================
- Hits         8195     8193       -2     
+ Misses       1398     1393       -5     
Flag Coverage Δ
integrationtests 73.98% <ø> (-0.27%) ⬇️
unittests 58.62% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 91.05% <ø> (+0.59%) ⬆️
sdk/python/feast/flags.py 100.00% <ø> (ø)
sdk/python/feast/flags_helper.py 100.00% <ø> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c53177...7327b1c. Read the comment docs.

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you missed a couple spots. e.g. feature_store.yaml files that have python_feature_server: true (there's one in the java serving file + the helm charts at least)

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Copy link
Collaborator Author

felixwang9817 commented Feb 2, 2022

@adchia good catch, I think all of them have been removed now

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia adchia merged commit 97a614e into feast-dev:master Feb 2, 2022
@felixwang9817 felixwang9817 deleted the graduate_feature_server branch February 2, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants