-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate Python feature server #2263
Graduate Python feature server #2263
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2263 +/- ##
==========================================
+ Coverage 85.42% 85.46% +0.04%
==========================================
Files 112 112
Lines 9593 9586 -7
==========================================
- Hits 8195 8193 -2
+ Misses 1398 1393 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think you missed a couple spots. e.g. feature_store.yaml files that have python_feature_server: true
(there's one in the java serving file + the helm charts at least)
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@adchia good catch, I think all of them have been removed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: This PR graduates the Python feature server from alpha status by removing the alpha flag check and modifying the docs. It also deletes some useless doc files.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: