Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests (test_online_store_cleanup & test_feature_get_online_features_types_match) #2276

Merged
merged 4 commits into from
Feb 6, 2022

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Feb 3, 2022

Signed-off-by: pyalex moskalenko.alexey@gmail.com

What this PR does / why we need it:

Several issues addressed in this PR:

  1. Test environment time range (start and end dates) was instantiated once on tests start. Which could be an issue when tests are started at the end of the hour and then continued to the next hour. So there will be difference between generated datasets boundaries and environment start and end timestamps.
  2. In test_online_store_cleanup some online stores (like dynamo) can have eventual consistency of schema. So when table was deleted it might need some time before it can be recreated.
  3. Bug with inferring feature type when all values are empty list.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #2276 (105d014) into master (bb676f2) will increase coverage by 27.46%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2276       +/-   ##
===========================================
+ Coverage   58.60%   86.06%   +27.46%     
===========================================
  Files         116      116               
  Lines        9810     9820       +10     
===========================================
+ Hits         5749     8452     +2703     
+ Misses       4061     1368     -2693     
Flag Coverage Δ
integrationtests 74.78% <84.21%> (?)
unittests 58.55% <26.31%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/type_map.py 68.51% <66.66%> (+28.39%) ⬆️
.../integration/online_store/test_universal_online.py 97.17% <80.00%> (+82.17%) ⬆️
...ts/integration/feature_repos/repo_configuration.py 94.44% <100.00%> (+49.07%) ⬆️
...s/integration/registration/test_universal_types.py 98.78% <100.00%> (+63.59%) ⬆️
sdk/python/feast/data_source.py 60.55% <0.00%> (+0.39%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 95.27% <0.00%> (+1.57%) ⬆️
sdk/python/feast/errors.py 70.51% <0.00%> (+3.20%) ⬆️
sdk/python/feast/online_response.py 77.77% <0.00%> (+3.70%) ⬆️
sdk/python/feast/feature.py 90.24% <0.00%> (+4.87%) ⬆️
sdk/python/feast/infra/provider.py 89.16% <0.00%> (+5.00%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb676f2...105d014. Read the comment docs.

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@feast-ci-bot feast-ci-bot added size/M and removed size/S labels Feb 4, 2022
@pyalex pyalex added the kind/bug label Feb 4, 2022
@pyalex pyalex changed the title [WIP] Debug flaky types test Fix flaky types test Feb 4, 2022
@pyalex pyalex removed the ok-to-test label Feb 4, 2022
@pyalex pyalex changed the title Fix flaky types test Fix flaky tests (test_online_store_cleanup & test_feature_get_online_features_types_match) Feb 4, 2022
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fs.materialize(
environment.start_date,
environment.end_date
- timedelta(hours=1) # throwing out last record to make sure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking, but kind of confusing why this ensures we infer from all empty values

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit aeaeb91 into feast-dev:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants