-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor universal test data to have more well defined types #2340
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2340 +/- ##
==========================================
+ Coverage 86.51% 86.54% +0.03%
==========================================
Files 116 117 +1
Lines 9698 9753 +55
==========================================
+ Hits 8390 8441 +51
- Misses 1308 1312 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
btw @adchia looks like unit tests are failing here with |
0ea424f
to
4e6b0be
Compare
done! |
…tead of loosely typed dictionaries Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
4e6b0be
to
55672e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#2340) * Refactor universal test suite to generate fixtures as dataclasses instead of loosely typed dictionaries Signed-off-by: Danny Chiao <danny@tecton.ai> * lint Signed-off-by: Danny Chiao <danny@tecton.ai> * lint Signed-off-by: Danny Chiao <danny@tecton.ai> * other lint Signed-off-by: Danny Chiao <danny@tecton.ai> * other lint Signed-off-by: Danny Chiao <danny@tecton.ai> * test fix Signed-off-by: Danny Chiao <danny@tecton.ai> * test fix Signed-off-by: Danny Chiao <danny@tecton.ai>
🎉 This PR is included in version 0.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What this PR does / why we need it:
Before, the test data and test objects used for the universal test suite tended to be a Dict[str, Any] with hardcoded keys. This converts those into data classes which allows for much better IDE integrations.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: