Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Have integration tests also run when a PR is LGTM'd #2385

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Mar 8, 2022

What this PR does / why we need it:
Existing integration tests only run on approval or ok-to-test, when in practice often the last label is actually lgtm
Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia requested a review from a team as a code owner March 8, 2022 01:05
@adchia adchia requested review from pyalex and removed request for a team March 8, 2022 01:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #2385 (25ba30e) into master (a985f1d) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2385      +/-   ##
==========================================
- Coverage   84.42%   84.35%   -0.08%     
==========================================
  Files         122      122              
  Lines       10732    10732              
==========================================
- Hits         9061     9053       -8     
- Misses       1671     1679       +8     
Flag Coverage Δ
integrationtests 74.17% <ø> (-0.31%) ⬇️
unittests 56.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
sdk/python/feast/go_server.py 64.57% <0.00%> (-0.58%) ⬇️
.../integration/online_store/test_universal_online.py 82.29% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a985f1d...25ba30e. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants