Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reintroduce redis services at 6379 #2395

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

achals
Copy link
Member

@achals achals commented Mar 10, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
We moved this to a github action in #2350 and #2354 but this change wasn't needed. I'd like to move the tests back to using the standard redis port so that the tests can be run while developing locally without any changes.

Corresponding test changes to use this redis instance and remove the old one will be in a followup PR.

Which issue(s) this PR fixes:

Fixes #

@achals achals requested a review from a team as a code owner March 10, 2022 18:33
@achals achals requested review from adchia and removed request for a team March 10, 2022 18:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #2395 (85a4074) into master (ae133fd) will decrease coverage by 1.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2395      +/-   ##
==========================================
- Coverage   84.43%   82.86%   -1.58%     
==========================================
  Files         122      122              
  Lines       10732    11493     +761     
==========================================
+ Hits         9062     9524     +462     
- Misses       1670     1969     +299     
Flag Coverage Δ
integrationtests 75.46% <ø> (+0.97%) ⬆️
unittests 56.51% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 65.30% <0.00%> (-17.47%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 80.84% <0.00%> (-15.22%) ⬇️
sdk/python/feast/feature_store.py 86.66% <0.00%> (-4.32%) ⬇️
sdk/python/feast/go_server.py 62.19% <0.00%> (-2.95%) ⬇️
...tion/feature_repos/integration_test_repo_config.py 100.00% <0.00%> (ø)
sdk/python/feast/infra/local.py 95.55% <0.00%> (+0.10%) ⬆️
sdk/python/tests/conftest.py 89.43% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae133fd...85a4074. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals force-pushed the achal/reintro-redis branch 3 times, most recently from 940da68 to 85a4074 Compare March 10, 2022 19:07
@achals achals changed the title Reintroduce redis services at 6379 ci: Reintroduce redis services at 6379 Mar 10, 2022
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a supercharge

.github/workflows/master_only.yml Show resolved Hide resolved
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants