Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mark DynamoDB's templating logic experimental and add a TODO #2439

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

achals
Copy link
Member

@achals achals commented Mar 22, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Links this code to #2438.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested a review from a team as a code owner March 22, 2022 21:38
@achals achals requested review from mavysavydav and removed request for a team March 22, 2022 21:38
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #2439 (3def13e) into master (5e6d9bc) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2439      +/-   ##
==========================================
- Coverage   83.51%   83.47%   -0.04%     
==========================================
  Files         123      123              
  Lines       10762    10762              
==========================================
- Hits         8988     8984       -4     
- Misses       1774     1778       +4     
Flag Coverage Δ
integrationtests 72.92% <ø> (-0.32%) ⬇️
unittests 57.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/dynamodb.py 86.33% <ø> (ø)
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
.../integration/online_store/test_universal_online.py 70.82% <0.00%> (-0.48%) ⬇️
...python/feast/infra/offline_stores/offline_store.py 83.33% <0.00%> (ø)
sdk/python/feast/infra/online_stores/datastore.py 90.52% <0.00%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6d9bc...3def13e. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit a734c45 into feast-dev:master Mar 22, 2022
@achals achals deleted the achal/template-todo branch March 22, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants