-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deprecate table_ref
parameter for BigQuerySource
#2502
chore: Deprecate table_ref
parameter for BigQuerySource
#2502
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8062378
to
fee3019
Compare
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
fee3019
to
fde556a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report
@@ Coverage Diff @@
## master #2502 +/- ##
===========================================
+ Coverage 58.97% 84.56% +25.59%
===========================================
Files 129 130 +1
Lines 10987 11043 +56
===========================================
+ Hits 6480 9339 +2859
+ Misses 4507 1704 -2803
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: The
table_ref
parameter was scheduled for deprecation in Feast 0.20 in #2336. This PR deprecates the parameter.Which issue(s) this PR fixes:
Fixes #