Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for Go feature server #2540

Merged
merged 8 commits into from
Apr 14, 2022

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: This PR adds docs for the Go feature server.

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 requested a review from a team as a code owner April 13, 2022 22:35
@felixwang9817 felixwang9817 requested review from achals and removed request for a team April 13, 2022 22:35
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #2540 (fbf4cca) into master (9025280) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
- Coverage   81.65%   81.52%   -0.13%     
==========================================
  Files         141      141              
  Lines       12011    12011              
==========================================
- Hits         9807     9792      -15     
- Misses       2204     2219      +15     
Flag Coverage Δ
integrationtests 73.47% <100.00%> (-0.48%) ⬇️
unittests 57.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 89.59% <ø> (ø)
sdk/python/feast/feature_store.py 89.34% <100.00%> (ø)
sdk/python/feast/repo_config.py 89.52% <100.00%> (ø)
...tion/feature_repos/integration_test_repo_config.py 92.30% <100.00%> (ø)
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...ython/feast/embedded_go/online_features_service.py 96.42% <0.00%> (-0.90%) ⬇️
.../integration/online_store/test_universal_online.py 92.59% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9025280...fbf4cca. Read the comment docs.

docs/SUMMARY.md Outdated
@@ -82,6 +82,7 @@
* [.feastignore](reference/feature-repository/feast-ignore.md)
* [Feature servers](reference/feature-servers/README.md)
* [Local feature server](reference/feature-servers/local-feature-server.md)
* [Go feature server](reference/feature-servers/go-feature-server.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good, but the only nit I have is that Go feature server is a bit misleading since it's not just Go, and there's no standalone go feature server that can be deployed.

I'd probably called this Go-based feature retrieval and update the docs and flag. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it in the feature servers folder since I think out of all folders it's still most relevant to Feature Servers.


## Usage

To enable the Go feature server, set `go_feature_server: True` in your `feature_store.yaml`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention that this week be turned on by default at some future version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

felixwang9817 and others added 7 commits April 14, 2022 15:05
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit da1ddab into feast-dev:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants