-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add docs for Go feature server #2540
docs: Add docs for Go feature server #2540
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
- Coverage 81.65% 81.52% -0.13%
==========================================
Files 141 141
Lines 12011 12011
==========================================
- Hits 9807 9792 -15
- Misses 2204 2219 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
docs/SUMMARY.md
Outdated
@@ -82,6 +82,7 @@ | |||
* [.feastignore](reference/feature-repository/feast-ignore.md) | |||
* [Feature servers](reference/feature-servers/README.md) | |||
* [Local feature server](reference/feature-servers/local-feature-server.md) | |||
* [Go feature server](reference/feature-servers/go-feature-server.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good, but the only nit I have is that Go feature server is a bit misleading since it's not just Go, and there's no standalone go feature server that can be deployed.
I'd probably called this Go-based feature retrieval and update the docs and flag. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it in the feature servers
folder since I think out of all folders it's still most relevant to Feature Servers.
|
||
## Usage | ||
|
||
To enable the Go feature server, set `go_feature_server: True` in your `feature_store.yaml`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mention that this week be turned on by default at some future version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
3d63258
to
ef54c01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
1c65e0e
to
86ac5ba
Compare
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: This PR adds docs for the Go feature server.
Which issue(s) this PR fixes:
Fixes #