Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in core not setting default Kafka source #297

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Fix bug in core not setting default Kafka source #297

merged 2 commits into from
Nov 8, 2019

Conversation

woop
Copy link
Member

@woop woop commented Nov 8, 2019

No description provided.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member Author

woop commented Nov 8, 2019

/lgtm

@feast-ci-bot
Copy link
Collaborator

@woop: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop woop added the lgtm label Nov 8, 2019
@woop woop merged commit 10db343 into feast-dev:0.3-dev Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants