Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Suppress alpha warnings in test. Fix entity serialization in test #3029

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 6, 2022

What this PR does / why we need it:
The make test-python and make test-python-integration-local commands were littered with warnings. This suppresses that to make for a better testing experience.

Note: test_lambda fails when switching to entity_key_serialization_version=2 so this temporarily keeps it at 1 for that test

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #3029 (0e07dd7) into master (4bba787) will increase coverage by 9.91%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##           master    #3029      +/-   ##
==========================================
+ Coverage   67.72%   77.63%   +9.91%     
==========================================
  Files         167      194      +27     
  Lines       14679    16109    +1430     
==========================================
+ Hits         9941    12507    +2566     
+ Misses       4738     3602    -1136     
Flag Coverage Δ
integrationtests 67.52% <59.25%> (-0.21%) ⬇️
unittests 59.32% <29.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/driver_test_data.py 100.00% <ø> (ø)
sdk/python/tests/integration/e2e/test_usage_e2e.py 100.00% <ø> (ø)
...ts/integration/feature_repos/repo_configuration.py 86.51% <ø> (ø)
...sts/integration/registration/test_feature_store.py 100.00% <ø> (ø)
...n/tests/integration/registration/test_inference.py 100.00% <ø> (ø)
...t/infra/online_store/test_dynamodb_online_store.py 100.00% <ø> (+74.86%) ⬆️
...n/tests/unit/infra/scaffolding/test_repo_config.py 100.00% <ø> (+61.22%) ⬆️
...thon/tests/unit/infra/test_inference_unit_tests.py 100.00% <ø> (+84.86%) ⬆️
...unit/local_feast_tests/test_local_feature_store.py 98.79% <ø> (+67.46%) ⬆️
...n/tests/unit/online_store/test_online_retrieval.py 100.00% <ø> (+84.94%) ⬆️
... and 109 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Collaborator

@kevjumba kevjumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -6,7 +6,7 @@
from pandas.testing import assert_frame_equal as pd_assert_frame_equal
from pytz import utc

from feast import FeatureStore, utils
from feast import FeatureService, FeatureStore, utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally these imports should come from feast.feature_service, feast.feature_store, etc.

Also, utils :(

Comment on lines +36 to +39
# TODO(adchia): figure out why entity_key_serialization_version 2 breaks with this test
lambda_environment = construct_test_environment(
lambda_config, None, entity_key_serialization_version=1
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably becase we need to build and push a new docker image (that uses the new version number). The docker image isn't automatically updated via CI at the moment.

@@ -8,7 +8,7 @@
import dill
from typeguard import typechecked

from feast import utils
from feast import flags_helper, utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same import comment.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevjumba kevjumba merged commit 1996596 into feast-dev:master Aug 8, 2022
@adchia adchia deleted the fixWarnings branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants