fix: Add check for bool type in addition to sample #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Beauchamp <ryan.beauchamp@ezcater.com>
beauchbum
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, beauchbum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kevjumba
pushed a commit
that referenced
this pull request
Jan 31, 2023
# [0.29.0](v0.28.0...v0.29.0) (2023-01-31) ### Bug Fixes * Add check for bool type in addition to sample ([#3452](#3452)) ([1c7c491](1c7c491)) * Buggy SQL for postgres source ([#3424](#3424)) ([1ea100e](1ea100e)) * Ensure no duplicates in `fv.schema` ([#3460](#3460)) ([08ffa8d](08ffa8d)) * Fix delete sfv twice issue ([#3466](#3466)) ([dfd5eae](dfd5eae)) * Stream feature view UI shows transformation issue ([#3464](#3464)) ([1ef5137](1ef5137)) * Update registry.refresh to have a default arg ([#3450](#3450)) ([2f7c4ed](2f7c4ed)) * Updating the batch field so that you can query create and event date. ([#3411](#3411)) ([01ab462](01ab462)), closes [#3401](#3401) ### Features * Add data source search ([#3449](#3449)) ([fbbb293](fbbb293)) * Adding list_validation_references for default and sql registry ([#3436](#3436)) ([21dd253](21dd253)) * Make UI accessible behind proxy ([#3428](#3428)) ([753d8db](753d8db))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Beauchamp ryan.beauchamp@ezcater.com
What this PR does / why we need it:
The current implementation throws an exception when
sample == Falseas it enters this conditional:This PR adds an additional check to bypass this condition when dealing with
bool.Which issue(s) this PR fixes:
Fixes #3451