Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch retrieval tests #357

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Conversation

zhilingc
Copy link
Collaborator

@zhilingc zhilingc commented Dec 9, 2019

This set of batch tests tests the following cases with a toy dataset:

  • order_by_creation_time
  • additional_columns_in_entity_table
  • point_in_time_correctness_join
  • multiple_featureset_joins

An example of a successful test run can be found here

@zhilingc zhilingc changed the title Batch tests Batch retrieval tests Dec 9, 2019
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Dec 9, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit e4f2756 into feast-dev:master Dec 9, 2019
@feast-ci-bot
Copy link
Collaborator

@zhilingc: Updated the config configmap in namespace default using the following files:

  • key config.yaml using file .prow/config.yaml

In response to this:

This set of batch tests tests the following cases with a toy dataset:

  • order_by_creation_time
  • additional_columns_in_entity_table
  • point_in_time_correctness_join
  • multiple_featureset_joins

An example of a successful test run can be found here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants