Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unwanted excessive splitting of gcs path, so expected gcs parquet paths are returned from BigQueryRetrievalJob.to_remote_storage() #3713

Conversation

crispin-ki
Copy link
Contributor

@crispin-ki crispin-ki commented Aug 7, 2023

What this PR does / why we need it:
See #3712

Which issue(s) this PR fixes:

Fixes #3712

@crispin-ki crispin-ki force-pushed the fix-to-remote-storage-return-value-for-big-query-retrieval-job branch from fa217c3 to 4b7e490 Compare August 7, 2023 17:44
@crispin-ki crispin-ki changed the title Remove unwanted excessive splitting of gcs path fix: Remove unwanted excessive splitting of gcs path, so expected gcs parquet paths are returned from BigQueryRetrievalJob.to_remote_storage() Aug 7, 2023
@crispin-ki crispin-ki marked this pull request as ready for review August 7, 2023 17:46
@crispin-ki crispin-ki force-pushed the fix-to-remote-storage-return-value-for-big-query-retrieval-job branch from 4b7e490 to 757c79e Compare August 7, 2023 17:51
Signed-off-by: Crispin Logan <crispinlogan@hotmail.co.uk>
@crispin-ki crispin-ki force-pushed the fix-to-remote-storage-return-value-for-big-query-retrieval-job branch from 757c79e to 210173b Compare August 7, 2023 17:53
@crispin-ki
Copy link
Contributor Author

Tagging @achals - as I see you did the initial PR to implement this in #2918

@crispin-ki
Copy link
Contributor Author

Closing and reopening in #3730 (done under a different GH account)

@crispin-ki crispin-ki closed this Aug 15, 2023
@crispin-ki crispin-ki deleted the fix-to-remote-storage-return-value-for-big-query-retrieval-job branch August 15, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants