fix: Update SparkSource to have proper comparable that inspects SparkOptions #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calvin Hopkins <thechopkins@outlook.com>
thechopkins
changed the title
thechopkins
changed the title
Signed-off-by: Calvin Hopkins <thechopkins@outlook.com>
Signed-off-by: Calvin Hopkins <thechopkins@outlook.com>
rebstastic
reviewed
Oct 26, 2023
| # Note: Python requires redefining hash in child classes that override __eq__ | ||
| def __hash__(self): | ||
|
|
||
| return super().__hash__() |
There was a problem hiding this comment.
Should this also include self.spark_options?
There was a problem hiding this comment.
It doesn't necessarily need to as the two pieces of logic are used for different things. Take a look at the redshift_source.py example for how it is implemented elsewhere.
|
looks like linter is failing here. @thechopkins can you update? |
|
closing out as this was addressed via the mentioned PR 4028. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This updates the
SparkSourcedata type to be properly comparable. The previous form defaults to using the__eq__implementation from theDataSourceclass. This misses updates to additional properties on theSparkSourceclass (i.e. anything that feeds into theSparkOptionsclass).This PR resolves this and adds tests to confirm the updated functionality. This means that
FeatureStore.plan()andFeatureStore.apply()will properly pick up changes toSparkSourcescorrectly.