Change error store to be part of configuration instead #39
Conversation
ingestion/src/main/java/feast/storage/service/ErrorsStoreService.java
Outdated
Show resolved
Hide resolved
ingestion/src/main/java/feast/ingestion/boot/ImportJobModule.java
Outdated
Show resolved
Hide resolved
|
We could change the [Error|Serving|Warehouse]Store classes to have factory in the name if that makes them make more sense. I just found it very verbose. |
|
/retest |
zhilingc
force-pushed
the
error-store-fix
branch
from
53f40fd to
578003f
Compare
|
/retest |
| @@ -38,7 +39,7 @@ | |||
|
|
|||
| public static List<ErrorsStore> getAll() { | |||
| return Lists.newArrayList( | |||
| Iterators.concat(manuallyRegistered.iterator(), serviceLoader.iterator())); | |||
| Iterators.concat(manuallyRegistered.iterator(), serviceLoader.iterator())); | |||
There was a problem hiding this comment.
This is weird, are you using the google-java-format plugin or the imported googles styles xml?
https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml
The imports don't get rearranged for me either.
|
Looks good except for formatting and import org, which need the google styles applied. If the google-java-format plugin neglects to org imports correctly. So instead, import the intellij styles. |
|
We should definitely merge this one before I merge this one before PR #52 |
ingestion/src/main/java/feast/ingestion/options/ImportJobOptions.java
Outdated
Show resolved
Hide resolved
|
/assign pradithya |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Terraform provider issue databricks/terraform-provider-databricks#123 has been fixed, removing the workaround
Adding registry server (UT to be completed)
Fixes #27.
This change requires core to be deployed with the following additional configuration:
feast.jobs.errorsStoreTypefeast.jobs.errorsStoreOptionswhich define where (and how) to write the error logs of each ingestion job. These options are passed in as flags to the ingestion jar when a job is run. Internally to ingestion a storage spec is still used.