Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protos with Tensorflow data validation schema #438

Conversation

davidheryanto
Copy link
Collaborator

What this PR does / why we need it:
This pull request is regarding feature validation in Feast. It updates EntitySpec and FeatureSpec protos with fields to specify constaints for the values. The constraint specs are adapted from Tensorflow metadata schema: https://github.com/tensorflow/metadata/blob/3b9d4114c6856ce18b7819023acb94f07183d348/tensorflow_metadata/proto/v0/schema.proto.

Only presence_constraints, shape_type and domain_info are currently added to EntitySpec and FeatureSpec because it is adequate for the current validation requirement in Feast and to ensure integration with Tensorflow data validation works correctly, before adding more features supported in Tensorflow validation.

Which issue(s) this PR fixes:
Partially addresses #172

Does this PR introduce a user-facing change?:
No, user-facing change with updates in Feast SDK will follow in subsequent pull requests.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit ba1c828 into feast-dev:master Jan 20, 2020
@ches
Copy link
Member

ches commented Jan 24, 2020

I think I've just learned of the Feature Validation RFC, perhaps it could be referenced in the PR description. Although I believe it's only currently accessible to feast-dev—I was wondering if there's a plan to make these publicly readable, when I just found that making this one public was an action item from a December community call 😇

I've taken the liberty to add an agenda point for next call about making these available for feedback earlier.

@woop
Copy link
Member

woop commented Jan 29, 2020

I think I've just learned of the Feature Validation RFC, perhaps it could be referenced in the PR description. Although I believe it's only currently accessible to feast-dev—I was wondering if there's a plan to make these publicly readable, when I just found that making this one public was an action item from a December community call

I've taken the liberty to add an agenda point for next call about making these available for feedback earlier.

Damn we messed up again. Feel free to add comments to the document. We're planning to keep fleshing things out over in the RFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants