chore: Make feature server test a unit test #4694
Conversation
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
robhowley
changed the title
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
Signed-off-by: Rob Howley <howley.robert@gmail.com>
|
|
||
|
|
||
| @pytest.mark.integration | ||
| @pytest.mark.universal_online_stores |
There was a problem hiding this comment.
This runs the tests for all online stores and basically tests the feature server end to end.
There was a problem hiding this comment.
it does, but using the fake server via fastapi testclient so not a "true" integration e2e. what ends up happening is that it's basically a unit test of the server and integration test for the feature store. the integration test of the feature store w the diff online stores already happens in test_universal_online. there isn't, however, a test suite dedicated to working w the server, only that implicit one baked into this file.
since this construct is proving to be complicated and brittle, seemed much simpler to break the implicit unit test out from the integration test and let the two exist on their own. imo if we really wanted a full e2e we'd start up a server and make calls to it w a regular client, not the fastapi one. reasonable people can def disagree on this file, but figured worth considering this option since integration tests have been failing inconsistently.
There was a problem hiding this comment.
Cool, I can get behind that.
* make feature server tests unit tests, remove integration Signed-off-by: Rob Howley <howley.robert@gmail.com> * use local example repo for test Signed-off-by: Rob Howley <howley.robert@gmail.com> * use example repo 1, switch to drive loc Signed-off-by: Rob Howley <howley.robert@gmail.com> * missing timestamp in payload Signed-off-by: Rob Howley <howley.robert@gmail.com> * combine tests Signed-off-by: Rob Howley <howley.robert@gmail.com> * simplify the request bodies Signed-off-by: Rob Howley <howley.robert@gmail.com> * use diff feature view Signed-off-by: Rob Howley <howley.robert@gmail.com> * fix feature name Signed-off-by: Rob Howley <howley.robert@gmail.com> * approx equal Signed-off-by: Rob Howley <howley.robert@gmail.com> * approx equal Signed-off-by: Rob Howley <howley.robert@gmail.com> * fix response format assertion Signed-off-by: Rob Howley <howley.robert@gmail.com> * dont need lazy fixture, simplify Signed-off-by: Rob Howley <howley.robert@gmail.com> --------- Signed-off-by: Rob Howley <howley.robert@gmail.com>
What this PR does / why we need it:
test_universal_online, i.e. feature_store -> data_storeWhich issue(s) this PR fixes:
Misc