Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Address flakey online retrieval test #4698

Merged
merged 1 commit into from
Oct 25, 2024
Merged

chore: Address flakey online retrieval test #4698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions sdk/python/tests/integration/online_store/test_universal_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,11 +485,7 @@ def test_online_retrieval_with_event_timestamps(environment, universal_data_sour
assert_feature_store_universal_feature_views_response(df)


@pytest.mark.integration
@pytest.mark.universal_online_stores(only=["redis", "dynamodb", "postgres"])
async def test_async_online_retrieval_with_event_timestamps(
environment, universal_data_sources
):
async def _do_async_retrieval_test(environment, universal_data_sources):
fs = setup_feature_store_universal_feature_views(
environment, universal_data_sources
)
Expand All @@ -510,6 +506,22 @@ async def test_async_online_retrieval_with_event_timestamps(
await fs.close()


@pytest.mark.integration
@pytest.mark.universal_online_stores(only=["redis", "postgres"])
async def test_async_online_retrieval_with_event_timestamps(
environment, universal_data_sources
):
await _do_async_retrieval_test(environment, universal_data_sources)


@pytest.mark.integration
@pytest.mark.universal_online_stores(only=["dynamodb"])
async def test_async_online_retrieval_with_event_timestamps_dynamo(
environment, universal_data_sources
):
await _do_async_retrieval_test(environment, universal_data_sources)
Comment on lines +509 to +522
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscojavierarceo trying to test the theory here ... im not familiar w how the environment reuse works exactly, but if is then separating the tests should work. unless it's cached across tests and not just within a test.



@pytest.mark.integration
@pytest.mark.universal_online_stores
def test_online_list_retrieval(environment, universal_data_sources):
Expand Down
Loading