-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Clickhouse offline store #4725
Open
iamhatesz
wants to merge
12
commits into
feast-dev:master
Choose a base branch
from
iamhatesz:feast-clickhouse-offline-store
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Clickhouse offline store #4725
iamhatesz
wants to merge
12
commits into
feast-dev:master
from
iamhatesz:feast-clickhouse-offline-store
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Signed-off-by: Tomasz Wrona <tomasz@cast.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new contrib offline store backed by Clickhouse.
Which issue(s) this PR fixes:
Lack of Clickhouse support :)
Misc
The implementation is heavily based on the Postgres store and tested against it. The resulting features were identical to the point that it's possible with two different backends (e.g., different data types).
I added a helper to run integration tests:
make test-python-universal-clickhouse-offline
. Unfortunately, 3 test cases are failing:This is because Clickhouse doesn't support
Nullable(Array(...))
type. I could have addedtest_universal_types
to the ignore list, but I thought it's worth keeping it on, as many other test cases from this test are passing.