-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Operator example notebook & api reference docs #4807
base: master
Are you sure you want to change the base?
Conversation
Very exhaustive showcase of the main operator deployment functions.
until grpcurl -insecure -d '''' -format text feast-example-registry.feast.svc.cluster.local:443 grpc.health.v1.Health/Check; do echo waiting for registry; sleep 2; done #feast init
with mock.patch("click.prompt", side_effect=["postgres.feast.svc.cluster.local", "5432", "feast", "public", "feast", "feast"]):
with mock.patch("click.confirm", side_effect=[True]):
init_repo(project_directory, template)' > postgres-apply.py;
...
feast apply
...
CURRENT_TIME=$(date -u +"%Y-%m-%dT%H:%M:%S");
feast materialize-incremental $CURRENT_TIME |
e5ceeaf
to
9ca846b
Compare
217a013
to
fe000b1
Compare
488bfe3
to
c8d7c48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the few more kubectl exec
commands to run sample commands like feast XYZ list
to prove the repo was correctly created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems these notebooks have no output. While I agree that maintaining outputs in git can be challenging, having the outputs preserved is indeed very helpful when the notebooks from a browser. It provides immediate insight into the results of the experiment without needing to rerun it. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok, i hadn't thought of it that way. i'll add them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
d5e43b6
to
3f11fd8
Compare
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc