Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated sample secret following review #4811

Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat: Updated sample secret following review #4811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions infra/feast-operator/config/samples/v1alpha1_featurestore_db_persistence.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
apiVersion: v1
kind: Secret
metadata:
name: postgres-secret
namespace: test
stringData:
postgres-secret-parameters: |
path: postgresql+psycopg://postgres:mysecretpassword@127.0.0.1:55001/feast
cache_ttl_seconds: 60
sqlalchemy_config_kwargs:
echo: false
pool_pre_ping: true
postgres: |
host: 127.0.0.1
port: 55001
database: feast
db_schema: public
user: postgres
password: mysecretpassword
---
apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
Expand All @@ -12,31 +32,11 @@ spec:
type: postgres
secretRef:
name: postgres-secret
secretKeyName: postgres-secret-parameters # optional
registry:
local:
persistence:
store:
type: sql
secretRef:
name: postgres-secret
secretKeyName: postgres-secret-parameters # optional
---
apiVersion: v1
kind: Secret
metadata:
name: postgres-secret
stringData:
postgres-secret-parameters: |
path: postgresql+postgresql://postgres:mysecretpassword@127.0.0.1:55001/feast
cache_ttl_seconds: 60
sqlalchemy_config_kwargs:
echo: false
pool_pre_ping: true
postgres: |
host: 127.0.0.1
port: 55001
database: feast
db_schema: public
user: postgres
password: mysecretpassword
secretKeyName: postgres-secret-parameters # optional, will use store.type by default as the SecretKeyName if none is specified, in this case that's "sql"
Loading